Merged
Conversation
voorhs
requested review from
Samoed and
truff4ut
and removed request for
Samoed
Merged
Samoed
reviewed
Jan 19, 2025
autointent/configs/_optimization.py
Outdated
| seed: int = 0 | ||
| """Seed for the random number generator""" | ||
| data: DataConfig = field(default_factory=DataConfig) | ||
| data: DataConfig |
Member
There was a problem hiding this comment.
Надо будет продумать надо ли нам поддержку нескольких датасетов
Member
There was a problem hiding this comment.
Не понял что ты поменял, но ладно
Samoed
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Поддерживать сразу Python API и CLI тяжело. Предлагаю оставить только Python API. Если пользователю понадобится CLI, то пусть напишет для себя, обернув наш Python API с помощью argparse, click или что ему удобно.
Что думаете?
В следующем PR хочу настроить логирование нормально